-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: add pre-paid bonds #2730
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4033,7 +4033,7 @@ func (c *Core) GetDEXConfig(dexAddr string, certI any) (*Exchange, error) { | |
// activity without setting up account keys or communicating account identity | ||
// with the DEX. DiscoverAccount, Post Bond or Register (deprecated) may be used | ||
// to set up a trading account for this DEX if required. | ||
func (c *Core) AddDEX(dexAddr string, certI any) error { | ||
func (c *Core) AddDEX(appPW []byte, dexAddr string, certI any) error { | ||
if !c.IsInitialized() { // TODO: Allow adding view-only DEX without init. | ||
return fmt.Errorf("cannot register DEX because app has not been initialized") | ||
} | ||
|
@@ -4097,6 +4097,23 @@ func (c *Core) AddDEX(dexAddr string, certI any) error { | |
c.conns[dc.acct.host] = dc | ||
c.connMtx.Unlock() | ||
|
||
// If a password was provided, try discoverAccount, but OK if we don't find | ||
// it. | ||
if len(appPW) > 0 { | ||
crypter, err := c.encryptionKey(appPW) | ||
if err != nil { | ||
return codedError(passwordErr, err) | ||
} | ||
defer crypter.Close() | ||
|
||
paid, err := c.discoverAccount(dc, crypter) | ||
if err != nil { | ||
c.log.Errorf("discoverAccount error during AddDEX: %v", err) | ||
} else if paid { | ||
c.upgradeConnection(dc) | ||
} | ||
} | ||
|
||
return nil | ||
} | ||
|
||
|
@@ -7075,6 +7092,10 @@ func (c *Core) findBondKeyIdx(pkhEqualFn func(bondKey *secp256k1.PrivateKey) boo | |
// findBond will attempt to find an unknown bond and add it to the live bonds | ||
// slice and db for refunding later. Returns the bond strength if no error. | ||
func (c *Core) findBond(dc *dexConnection, bond *msgjson.Bond) (strength, bondAssetID uint32) { | ||
if bond.AssetID == account.PrepaidBondID { | ||
c.insertPrepaidBond(dc, bond) | ||
return bond.Strength, bond.AssetID | ||
Comment on lines
+7095
to
+7097
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason why we insert instead of checking db? I assume the redeemed prepaid bond was added to the db, no? |
||
} | ||
symb := dex.BipIDSymbol(bond.AssetID) | ||
bondIDStr := coinIDString(bond.AssetID, bond.CoinID) | ||
c.log.Warnf("Unknown bond reported by server: %v (%s)", bondIDStr, symb) | ||
|
@@ -7140,6 +7161,27 @@ func (c *Core) findBond(dc *dexConnection, bond *msgjson.Bond) (strength, bondAs | |
return strength, bondDetails.AssetID | ||
} | ||
|
||
func (c *Core) insertPrepaidBond(dc *dexConnection, bond *msgjson.Bond) { | ||
lockTime := bond.Expiry + dc.config().BondExpiry | ||
dbBond := &db.Bond{ | ||
Version: bond.Version, | ||
AssetID: bond.AssetID, | ||
CoinID: bond.CoinID, | ||
LockTime: lockTime, | ||
Strength: bond.Strength, | ||
Confirmed: true, | ||
} | ||
|
||
err := c.db.AddBond(dc.acct.host, dbBond) | ||
if err != nil { | ||
c.log.Errorf("Failed to store pre-paid bond dex %v: %w", dc.acct.host, err) | ||
} | ||
|
||
dc.acct.authMtx.Lock() | ||
dc.acct.bonds = append(dc.acct.bonds, dbBond) | ||
dc.acct.authMtx.Unlock() | ||
} | ||
|
||
func (dc *dexConnection) maxScore() uint32 { | ||
if maxScore := dc.config().MaxScore; maxScore > 0 { | ||
return maxScore | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove the nested if:
if acctExists && dc.acct.locked() { return 0, newError(acctKeyErr, "acct locked %s (login first)", host) }