Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: Display incoming transaction in Deposit modal #2685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterzen
Copy link
Member

This PR implements deposit transaction detection.

Closes #2662

Screenshot_2024-01-23_17-37-14

Screenshot_2024-01-23_17-38-03

Copy link
Contributor

@martonp martonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff only fixes the main issue of address reuse if the deposit modal remains open when the transaction is received. I think generally the user will not keep it open.

Maybe you can do something like this: 296ae25

@buck54321
Copy link
Member

Simpler approach in #2690. I'm not trying to steamroll you, @peterzen.

Address reuse and display of incoming deposits are separate issues, and displaying incoming deposits is largely resolved by recent txs ui.

@peterzen
Copy link
Member Author

peterzen commented Feb 5, 2024

Address reuse and display of incoming deposits are separate issues, and displaying incoming deposits is largely resolved by recent txs ui.

The confirmation in the modal would still be useful, it's standard pattern in wallets/dexes. How about rigging this UI onto #2690?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: Incoming tx detection in the Deposit dialogs
3 participants