[0.6] server/btc: use external fee rates #2638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
approved these changes
Dec 30, 2023
Comment on lines
+431
to
+438
| case <-tick.C: | ||
| feeRate := btc.fetchExternalBitcoinFeeRate(ctx) | ||
| if feeRate > 0 { | ||
| btc.feeRateCache.Lock() | ||
| btc.feeRateCache.stamp = time.Now() | ||
| btc.feeRateCache.feeRate = feeRate | ||
| btc.feeRateCache.Unlock() | ||
| } |
There was a problem hiding this comment.
Maybe try again sooner on a failure? In case of a one-off connection issue.
JoeGruffins
approved these changes
Jan 2, 2024
| wg.Add(1) | ||
| go func() { | ||
| defer wg.Done() | ||
| tick := time.NewTicker(time.Minute * 5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
estimatesmartfeeRPC is not very responsive to changing conditions and often gives fee rates that are too high. Try to use fee rates from mempool.space or btc.com before falling backestimatesmartfee. Retrieve rates every five minutes, preferring mempool.space. Fall back if rates are stale by 10 minutes.Some profiling of fee rate sources was done separately. Ask on Element for results if interested.