Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chaincfg: Update assume valid for release. #3263

Merged
merged 1 commit into from
May 14, 2024
Merged

chaincfg: Update assume valid for release. #3263

merged 1 commit into from
May 14, 2024

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented May 13, 2024 •
edited

This updates the assumed valid block for the main and test networks as follows:

mainnet: f04628f2fe7fd0d33055dc326936a6af3772ec5226525bc8fca50631f3081faa
testnet: 88d61d7609c06c8e171f050789f6649d21525a144b820026f7b396476a05a44b

Reviewers should verify that:

  • The mainnet block is at least 4032 blocks behind the current tip
  • The testnet block is at least 10080 blocks behind the current tip
  • The block hashes and heights match their local instances

The following commands may be used to verify the hashes:

$ dcrctl getblockhash 865184
f04628f2fe7fd0d33055dc326936a6af3772ec5226525bc8fca50631f3081faa
$ dcrctl --testnet getblockhash 1377455
88d61d7609c06c8e171f050789f6649d21525a144b820026f7b396476a05a44b

Closes #3252.

@davecgh davecgh added this to the 1.9.0 milestone May 13, 2024
@matheusd
Copy link
Member

Just to comment, as instructed in the matrix chat room, I also double checked the chain work parameter.

jholdstock
jholdstock approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified both correct

@davecgh
chaincfg: Update assume valid for release.
7e2f881 
This updates the assumed valid block for the main and test networks as
follows:

mainnet: f04628f2fe7fd0d33055dc326936a6af3772ec5226525bc8fca50631f3081faa
testnet: 88d61d7609c06c8e171f050789f6649d21525a144b820026f7b396476a05a44b
@davecgh davecgh force-pushed the chaincfg_update_assume_valid branch from 6e46f82 to 7e2f881 Compare May 14, 2024 13:44
@davecgh davecgh merged commit 7e2f881 into decred:master May 14, 2024
2 checks passed
@davecgh davecgh deleted the chaincfg_update_assume_valid branch May 14, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrick jrick jrick approved these changes

@matheusd matheusd matheusd approved these changes

@jholdstock jholdstock jholdstock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Update Assume Valid Hash for Release
4 participants
@davecgh @matheusd @jrick @jholdstock