with loop gone, better to defer the mtx unlock

decred · Apr 5, 2023 · b8eaded · b8eaded
1 parent ec9b072
commit b8eaded
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/mixing/mixpool/mixpool.go b/mixing/mixpool/mixpool.go
@@ -345,10 +345,9 @@ func (p *Pool) Receive(ctx context.Context, r *Received) error {
 	}
 
 	p.mtx.RLock()
+	defer p.mtx.RUnlock()
 
 	if run >= uint32(len(ses.runs)) {
-		p.mtx.RUnlock()
-
 		if err != nil {
 			return err
 		}
@@ -384,8 +383,6 @@ func (p *Pool) Receive(ctx context.Context, r *Received) error {
 		}
 	}
 
-	p.mtx.RUnlock()
-
 	return err
 }