fix: add timeout when MM active method hangs (#2240)

* fix: add timeout when MM active method hangs

* chore: remove console.log

* fix: test add delay inside provide

* test: fix logic

webapp/src/modules/wallet/utils.spec.ts

@@ -1,4 +1,4 @@
-import { select } from 'redux-saga/effects'
+import { delay, select } from 'redux-saga/effects'
 import { expectSaga } from 'redux-saga-test-plan'
 import {
   CONNECT_WALLET_FAILURE,
@@ -8,7 +8,7 @@ import {
 } from 'decentraland-dapps/dist/modules/wallet/actions'
 import { isConnecting } from 'decentraland-dapps/dist/modules/wallet/selectors'
 import { Wallet } from 'decentraland-dapps/dist/modules/wallet/types'
-import { formatBalance, waitForWalletConnectionAndIdentityIfConnecting } from './utils'
+import { WAIT_FOR_WALLET_CONNECTION_TIMEOUT, formatBalance, waitForWalletConnectionAndIdentityIfConnecting } from './utils'
 
 describe('when formatting the balance', () => {
   describe('and the number is 0', () => {
@@ -58,4 +58,15 @@ describe('when waiting for the wallet to connect', () => {
         .run()
     })
   })
+
+  describe('and the wallet connection times out', () => {
+    it('should finish waiting after the timeout', () => {
+      return expectSaga(waitForWalletConnectionAndIdentityIfConnecting)
+        .provide([
+          [select(isConnecting), true],
+          [delay(WAIT_FOR_WALLET_CONNECTION_TIMEOUT), void 0]
+        ])
+        .run()
+    })
+  })
 })

webapp/src/modules/wallet/utils.ts

@@ -1,5 +1,5 @@
 import { ethers } from 'ethers'
-import { race, select, take } from 'redux-saga/effects'
+import { delay, race, select, take } from 'redux-saga/effects'
 import { getConnectedProvider } from 'decentraland-dapps/dist/lib/eth'
 import {
   CONNECT_WALLET_FAILURE,
@@ -13,6 +13,7 @@ import { config } from '../../config'
 import { GENERATE_IDENTITY_FAILURE, GENERATE_IDENTITY_SUCCESS } from '../identity/actions'
 
 export const TRANSACTIONS_API_URL = config.get('TRANSACTIONS_API_URL')
+export const WAIT_FOR_WALLET_CONNECTION_TIMEOUT = 10000 // 10 seconds timeout
 
 export function shortenAddress(address: string) {
   if (address) {
@@ -49,7 +50,8 @@ export function* waitForWalletConnectionAndIdentityIfConnecting() {
   if (isConnectingToWallet) {
     const { success } = (yield race({
       success: take(CONNECT_WALLET_SUCCESS),
-      failure: take(CONNECT_WALLET_FAILURE)
+      failure: take(CONNECT_WALLET_FAILURE),
+      timeout: delay(WAIT_FOR_WALLET_CONNECTION_TIMEOUT)
     })) as { success: ConnectWalletSuccessAction; failure: ConnectWalletFailureAction }
     if (success) {
       yield race({