Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove imp import from xxxswf for python 3.12 compatability #841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cccs-jh
Copy link

@cccs-jh cccs-jh commented Feb 13, 2024

The imp module is removed in 3.12 and causes an error when loading xxxswf. The recommended replacement is importlib but here the use of imp is actually redundant. When yara isn't found the import yara statement already throws an ImportError for 3.5 and earlier, and for 3.6 and later it throws a ModuleNotFoundError which is a subclass of ImportError and is caught by the same try catch.

@decalage2 decalage2 self-requested a review February 13, 2024 10:45
@decalage2 decalage2 self-assigned this Feb 13, 2024
@decalage2 decalage2 added this to the oletools 0.60 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants