Massive speedup in analyze_macros #810
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Processing the same file went from 50s to 7s.
|
It seems there are a few other calls at other places in this file. If you want me to have a look and change them in a similar way, let me know. |
|
Is it really making such a huge difference? Wow. |
|
Yeah, I was quite surprised too, but also concatenating strings with And sadly, I cannot share the file, sorry, it comes from an internal phishing campaign from a third party. But I can tell you that it is a 1.8Mb word document with macros (obvs). So pretty big yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing the same file went from 50s to 7s.