Single independent commits #800
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These 6 tests made up more than two thirds of the overall test time. Add an option to disable them to motivate incorporation of regular testing in development cycle: set environment variable OLETOOLS_TEST_SKIP_SLOW=1 . However, these tests are there for a reason, therefore do not disable them by default (like the json dump test). Should do a standard run without "optimizations" like this one before committing to master, for example.
Olevba might get (and does get in our case) parts of files that were taken apart by an attachment interpreter. Olevba detects mso / ActiveMime components when embedded in an mhtml or excel2003 file, but fails to detect them when the input is pure mso. Fix that.
Oletools is now used in professional settings, so these warnings appear to naive users more and more often. These, however, do not appreciate such modesty, will more likely feel bewildered and insecure.
When deobfuscating text or rtf, sometimes have large (500k chars) lines. Do not try to fit that into regular memory, but split data into overlapping pieces of manageable size.
Office is likely to do it this way. This is a re-creation of an old commit from 2016, probably motivated by a sample obtained then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a summary of single-commit branches I gathered over the years. Each commit explains itself.
This is not for merging as-is but rather for cherry-picking individual commits. If that is too troublesome I'll gladly create individual branches