New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4387 video recording for Full Debrief. #5167
base: develop
Are you sure you want to change the base?
Conversation
…er recording button
Hello @saulhidalgoaular - I just downloaded this, and went to play with it. I enabled video recording in the prefs, and recorded the time moving forward. But when I stopped recording the Is it a different process to record to video? That reminds me - we could do with some tutorial content on how to record to video. I'll send you a link. |
Thanks for this @saulhidalgoaular The linter has spotted a bunch of improvements. Some are in our code, others in 3rd-party Monte code. Where the issue is in our code, and is in new code related to this issue, could you investigate/resolve them please? |
* @author Werner Randelshofer | ||
* @version 1.0 2011-03-19 Created. | ||
*/ | ||
public class MovieMaker { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @saulhidalgoaular - is there a use-case when we run this app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a tool to test manually the class that creates .mov files. You can upload some images and an audio and it creates a mov file from that. We don't have an use case in Debrief for this functionality. I am removing it.
By the way, there are many other classes like this one. Would you like me to delete them too? They are some tools to test partial functionality of the library.
chosen from the dropdown. Now It is only shown when It is enabled in the Preferences section.
Oh, @saulhidalgoaular and @helenayele - can users choose to only record the Debrief plot window? That's the most likely recording use-case. |
If you mean the only the map, currently it is not supported. I will work on this feature |
Kind-of. There is no "down-arrow" to act as a clue that there is a drop-down button. But, if I click in that area I do get the |
Hello @saulhidalgoaular - I've just had a play. A couple of items of feedback:
|
Have you configured ffmpeg? There is a setting section in the Preference for it. It looks like it is missing. |
Yes, that's totally the issue :-) Is it an option for us to include ffmpeg? Oh, I see it's quite large. In that case yes - it's better to have it configurable. Let me install/test. |
@saulhidalgoaular - the missing-ffmpeg issue is probably going to arise a lot. Can we run a check for the existence of the file in specified in the preference, and throw a suitable warning if the property is empty, or the file doens't exist? |
else if (DEBRIEF_PLOT_WINDOW.equals(preferenceStore.getString( | ||
P_SCREEN_AREA))) | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saulhidalgoaular - in this if
structure, should it be retrieving the viewport of the current editor? Oh, and it shouldn't include the tabs at the top. So, it's the content pane of the current editor, not the whole of the current editor - please.
Update: I just tried selecting the new option, but it still records the whole Debrief window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. It is still not implemented. I need to find out how to calculate the viewport area. I pushed it partially to fix the bug mentioned in the comment above. 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to find out how to calculate the viewport area.
I think it's something like this:
Fixes #4387