Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4387 video recording for Full Debrief. #5167

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

saulhidalgoaular
Copy link
Collaborator

@saulhidalgoaular saulhidalgoaular commented Jan 11, 2023

Fixes #4387

@auto-assign auto-assign bot requested a review from helenayele January 11, 2023 09:28
@saulhidalgoaular
Copy link
Collaborator Author

@IanMayo
Copy link
Member

IanMayo commented Feb 24, 2023

Hello @saulhidalgoaular - I just downloaded this, and went to play with it. I enabled video recording in the prefs, and recorded the time moving forward. But when I stopped recording the export to pptx dialog opened.

Is it a different process to record to video?

That reminds me - we could do with some tutorial content on how to record to video. I'll send you a link.

@IanMayo
Copy link
Member

IanMayo commented May 2, 2023

Thanks for this @saulhidalgoaular

The linter has spotted a bunch of improvements. Some are in our code, others in 3rd-party Monte code. Where the issue is in our code, and is in new code related to this issue, could you investigate/resolve them please?
https://www.codefactor.io/repository/github/debrief/debrief/pull/5167

* @author Werner Randelshofer
* @version 1.0 2011-03-19 Created.
*/
public class MovieMaker {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @saulhidalgoaular - is there a use-case when we run this app?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tool to test manually the class that creates .mov files. You can upload some images and an audio and it creates a mov file from that. We don't have an use case in Debrief for this functionality. I am removing it.

By the way, there are many other classes like this one. Would you like me to delete them too? They are some tools to test partial functionality of the library.

@IanMayo
Copy link
Member

IanMayo commented May 5, 2023

Note: on MS-Windows I don't see the drop-down control:
image

MS-Windows also can't replay the recorded video:
image

@saulhidalgoaular
Copy link
Collaborator Author

saulhidalgoaular commented Jul 5, 2023

Note: on MS-Windows I don't see the drop-down control: image

MS-Windows also can't replay the recorded video: image

Good afternoon. Which Windows' version have you tried? I am running it on Windows 10 and the dropdown button looks like this:

image
image

@IanMayo
Copy link
Member

IanMayo commented Jul 20, 2023

Oh, @saulhidalgoaular and @helenayele - can users choose to only record the Debrief plot window? That's the most likely recording use-case.

@saulhidalgoaular
Copy link
Collaborator Author

saulhidalgoaular commented Apr 3, 2024

image

I have added this option. Files generated are playable by Windows Media Player and "Movies & TV" without extra codecs.

@saulhidalgoaular
Copy link
Collaborator Author

Oh, @saulhidalgoaular and @helenayele - can users choose to only record the Debrief plot window? That's the most likely recording use-case.

If you mean the only the map, currently it is not supported. I will work on this feature

@saulhidalgoaular
Copy link
Collaborator Author

Note: on MS-Windows I don't see the drop-down control: image

Do you still have the Dropdown the missing?

@IanMayo
Copy link
Member

IanMayo commented Apr 3, 2024

Note: on MS-Windows I don't see the drop-down control: image

Do you still have the Dropdown the missing?

Am onsite right now, without access to MS-Windows. Will check tomorrow morning.

@IanMayo
Copy link
Member

IanMayo commented Apr 4, 2024

Do you still have the Dropdown the missing?

Kind-of. There is no "down-arrow" to act as a clue that there is a drop-down button. But, if I click in that area I do get the Video // PPTX popup menu.

@IanMayo
Copy link
Member

IanMayo commented Apr 4, 2024

Hello @saulhidalgoaular - I've just had a play. A couple of items of feedback:

  1. When I pressed "Stop recording" a file selector dialog opened. But, I saw that the time was still moving forward. Capture only ended once the output file was selected. We should pause the stepper on "Stop", and then do the file management stuff.
  2. It produced a .wmv of zero size. The issue is probably reported in this stack trace. Is it due to how the parameters are provided in MS-Windows?
    image

@saulhidalgoaular
Copy link
Collaborator Author

Hello @saulhidalgoaular - I've just had a play. A couple of items of feedback:

  1. When I pressed "Stop recording" a file selector dialog opened. But, I saw that the time was still moving forward. Capture only ended once the output file was selected. We should pause the stepper on "Stop", and then do the file management stuff.
  2. It produced a .wmv of zero size. The issue is probably reported in this stack trace. Is it due to how the parameters are provided in MS-Windows?
    image

Have you configured ffmpeg? There is a setting section in the Preference for it. It looks like it is missing.

image

@IanMayo
Copy link
Member

IanMayo commented Apr 4, 2024

Have you configured ffmpeg? There is a setting section in the Preference for it. It looks like it is missing.

Yes, that's totally the issue :-)

Is it an option for us to include ffmpeg? Oh, I see it's quite large. In that case yes - it's better to have it configurable. Let me install/test.

@IanMayo IanMayo closed this Apr 4, 2024
@IanMayo
Copy link
Member

IanMayo commented Apr 4, 2024

@saulhidalgoaular - the missing-ffmpeg issue is probably going to arise a lot. Can we run a check for the existence of the file in specified in the preference, and throw a suitable warning if the property is empty, or the file doens't exist?

@IanMayo IanMayo reopened this Apr 4, 2024
else if (DEBRIEF_PLOT_WINDOW.equals(preferenceStore.getString(
P_SCREEN_AREA)))
{

Copy link
Member

@IanMayo IanMayo Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saulhidalgoaular - in this if structure, should it be retrieving the viewport of the current editor? Oh, and it shouldn't include the tabs at the top. So, it's the content pane of the current editor, not the whole of the current editor - please.

Update: I just tried selecting the new option, but it still records the whole Debrief window.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. It is still not implemented. I need to find out how to calculate the viewport area. I pushed it partially to fix the bug mentioned in the comment above. 😢

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to find out how to calculate the viewport area.

I think it's something like this:

https://stackoverflow.com/a/11780445/92441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture moving plot to Video file
3 participants