Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5148 - Store viewport with bookmark #5153

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ayeshare
Copy link
Collaborator

@ayeshare ayeshare commented Mar 9, 2022

supports #5148

Supercedes #5151, which was in wrong repo.

@auto-assign auto-assign bot requested a review from helenayele March 9, 2022 11:12
@IanMayo IanMayo changed the title rechecking in to branch with changes for boookmarks add viewport Store viewport with bookmark Mar 9, 2022
@IanMayo IanMayo changed the title Store viewport with bookmark #5148 - Store viewport with bookmark Mar 9, 2022
@IanMayo
Copy link
Member

IanMayo commented Mar 14, 2022

Hello @ayeshare - it doesn't always zoom in on the viewport. but I think I've spotted a pattern of behaviour. If we have a bookmark with time and viewport, then if we are already at that time, then it doesn't zoom in.

Hmm, or it moves to time, but only changes viewport on next update. I've tried to capture it here:
7170b76fa8eba1dabe53da3f900a439b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants