Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add const labels to isolate metrics.
Use case:
I am writing a logs reporter that pushing logs into different kafka topics, and I used sarama as the kafkaclient SDK, sarama used go metrics to collect metrics and I would like to export the metrics to prometheus, so I used go-metrics-prometheus to do that for me, but the original version of go-metrics-prometheus can isoltate metrics just by namespace/subsystem, and if I set different namespace/subsystem to different topics, it will produce different metrics names, which is not good for configuring metrics panels in grafana.
Now, I add a const label for each topic, the metrics names keep the same for each topics, but can be ioslated by the label values, I think it is useful for the guys who have the same requirements as me.