Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const labels to isolate metrics #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gunli
Copy link

@gunli gunli commented Apr 3, 2023

Add const labels to isolate metrics.

Use case:
I am writing a logs reporter that pushing logs into different kafka topics, and I used sarama as the kafkaclient SDK, sarama used go metrics to collect metrics and I would like to export the metrics to prometheus, so I used go-metrics-prometheus to do that for me, but the original version of go-metrics-prometheus can isoltate metrics just by namespace/subsystem, and if I set different namespace/subsystem to different topics, it will produce different metrics names, which is not good for configuring metrics panels in grafana.

Now, I add a const label for each topic, the metrics names keep the same for each topics, but can be ioslated by the label values, I think it is useful for the guys who have the same requirements as me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant