Make sure the document processed in background.js has a title element. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e has a value and download can succeed.
WetHat
changed the title
|
I think this PR can be adapted in the obsidian feature too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #310: which describes a download failure for a specific website, because
pageTitleis empty.The proposed fix here makes sure that the HTML document processed in
background.jshas a proper<title>tag, so thatpageTitlecan be populated.Note: Despite a missing
<title>tag browsers manage to provide a useful window title. Hence the best place to fix this issue seems to becontentScript.jsbecause it is run in the context of the original HTML page