Prevent Readability.js from removing the <html> element if it has a class attribute with specific values #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attribute which matches removal criteria. Removal of the HTML element causies Markdownload to fail because: * the pageTitle is undefined * basicUri point to chrome-extension://nghfdnngoejlhedogdpikdlkmdfoojii/_generated_background_page.html rather than the actual web page * all local links are incorrect
WetHat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For web pages which have a HTML root tag with a
classattribute whose value matches the removal criteria ofReadability.jsThe problem is that
Readability.lsremoves the<html>root tag, as a consequence, uses the wrong urls. Also,Markdownloadloses access to the page meta-data.This pull request fixes issue #260 by removing the class attribute from the
<html>root tag.Following sites mentioned in issue #260 work correctly with this fix:
Note: This does not fix issue #201 !