-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Punctuation fixes #148
Open
deathsythe47
wants to merge
1
commit into
dear-github:master
Choose a base branch
from
deathsythe47:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Punctuation fixes #148
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,9 +35,9 @@ them, are: | |
at the top of the new issue / PR page instead of that link. Maintainers can | ||
choose to inline content there and / or link to other pages as appropriate. | ||
|
||
Hopefully none of these are a surprise to you as we’ve told you them before. | ||
Hopefully, none of these are a surprise to you, as we’ve told you them before. | ||
We’ve waited years now for progress on any of them. If GitHub were open source | ||
itself, we would be implementing these things ourselves as a community—we’re | ||
itself, we would be implementing these things ourselves as a community — we’re | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hyphens? Try a semicolon. They were not invented for C syntax. Hyphens are emotively used, but even non-liberal arts majors can learn to use semicolons. 😄 |
||
very good at that! | ||
|
||
Signed, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not valid. See:
https://en.oxforddictionaries.com/grammar/dash-and-em-dash
https://english.stackexchange.com/questions/214585/space-before-after-emdash-or-not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@resurtm to be fair, there is no way
communty-we're
is correct either