Added boost and Utilities serialization to cellid benchmark. #1
Conversation
| const auto cell2 = tr.create_cell_iterator(cid2); | ||
| #else | ||
| const auto cell2 = cid2.to_cell(tr); | ||
| #endif | ||
| c += cell2->index(); | ||
| } | ||
| std::cout << c << std::endl; |
There was a problem hiding this comment.
What is the purpose of this value c? Is it some kind of 'checksum'?
There was a problem hiding this comment.
We are compiling with optimizations. I was worried that the compiler would just optimize all of it away otherwise.
There was a problem hiding this comment.
Ah I understand. I'll add a comment.
cell_id/main.cc
Outdated
| @@ -54,24 +56,25 @@ void check (Triangulation<dim> &tr) | |||
| CellId cid2; | |||
| cidstream >> cid2; | |||
|
|
|||
| typename Triangulation<dim>::cell_iterator cell2 = cid2.to_cell(tr); | |||
|
|
|||
| #if DEAL_II_VERSION_GTE(9, 4, 0) | |||
There was a problem hiding this comment.
We introduced this new function during development of version 9.3.
Not all commits since the release of version 9.2 include this function, so with the (9,3,0) check this code would not compile on earlier commits.
Reading the README, I assume you want to run this benchmark on certain commits, and not only releases. I thought it would be safer to ask for a future release here, since the deprecated function still exists and does not do anything different. Using version 9.3.1 should also be possible here.
Added serialization variants as proposed in dealii/dealii#11446. Applied
clang-formaton the source file.This test now packs and unpacks every
CellIdone by one. It would also be interesting if we pack a whole set ofCellIds into one buffer, and extract them from it.However the critical use case in parallel applications is to pack cell-related data for transfer, which the current state of this test corresponds to. So it would be reasonable to keep this check as it is, with the two additional options as proposed in this PR.
What do you think?