Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mesh in a test #17025

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix mesh in a test #17025

merged 1 commit into from
May 17, 2024

Conversation

kronbichler
Copy link
Member

It turned out that the mesh created by hyper_shell when the boundary cells are curved by

hyper_ball(Triangulation<dim> &tria,
const Point<dim> &center = Point<dim>(),
const double radius = 1.,
const bool attach_spherical_manifold_on_boundary_cells = false);
upon refinement some invalid transformations are generated for some mappings (MappingQ(2) in this example). We should not do that. Found by looking at #16317.

Copy link
Member

@peterrum peterrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterrum
Copy link
Member

@kronbichler The serial tester is not passing.

@kronbichler
Copy link
Member Author

Indeed, I forgot that the text outputs actual numbers of the mesh. (Which is funny given that I spent quite some time to understand the test and the issue in the other PR.)

@marcfehling marcfehling merged commit f19c1c9 into dealii:master May 17, 2024
15 of 16 checks passed
@kronbichler kronbichler deleted the fix_hess branch May 17, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants