Use Kokkos::abort() where necessary.

[bangerth]

@masterleinad I must admit that I don't know the intricacies of what is or isn't available in Kokkos for specific versions. Does this seem right to address your comment that we can't call straight std::abort() in our assertion machinery?

If so, this fixes #16553.

[masterleinad]

You should be able to just call Kokkos::abort without distinguishing between host and device execution if you were only calling a plain std::abort before. We only have that separation in the Assert macro since we want to pass through more information that is not device-compatible.

[bangerth]

Even better, of course!

[luca-heltai]

I think you need to add a (""):

/__w/dealii/dealii/source/base/exceptions.cc:519:20: error: too few arguments to function ‘void Kokkos::abort(const char*)’
  519 |       Kokkos::abort();
      |       ~~~~~~~~~~~~~^~
In file included from /__w/dealii/dealii/bundled/kokkos-3.7.00/core/src/Kokkos_Core_fwd.hpp:57,
                 from /__w/dealii/dealii/bundled/kokkos-3.7.00/core/src/Kokkos_Core.hpp:55,
                 from /__w/dealii/dealii/include/deal.II/base/exceptions.h:25,
                 from /__w/dealii/dealii/source/base/exceptions.cc:15:
/__w/dealii/dealii/bundled/kokkos-3.7.00/core/src/impl/Kokkos_Error.hpp:230:56: note: declared here
  230 | KOKKOS_IMPL_ABORT_NORETURN KOKKOS_INLINE_FUNCTION void abort(
      |                                                        ^~~~~
/__w/dealii/dealii/source/base/exceptions.cc:520:5: error: ‘noreturn’ function does return [-Werror]
  520 |     }

[masterleinad]

I think you need to add a (""):

Yes, you need to provide an error string.

[bangerth]

Yes, I noticed too yesterday. I didn't see it because I merged @masterleinad suggestion on the web site, rather than making the change locally and compiling. I will get to fix this later today.

[bangerth]

OK, works now!

[tjhei]

I think it would make sense to leave a comment about the necessity to use the Kokkos version on device code but that it is equivalent to std::abort otherwise.

[bangerth]

I added the comment.