Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: fix typo in Config.cmake.in #16931

Merged
merged 1 commit into from Apr 29, 2024
Merged

CMake: fix typo in Config.cmake.in #16931

merged 1 commit into from Apr 29, 2024

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Apr 26, 2024

The file is named »deal.IIConfigGit.cmake« …

The file is named »deal.IIConfigGit.cmake«
set(DEAL_II_GIT_CONFIG "${DEAL_II_PATH}/${DEAL_II_PROJECT_CONFIG_RELDIR}/${DEAL_II_PROJECT_CONFIG_NAME}Git.cmake")
set(DEAL_II_GIT_CONFIG "${DEAL_II_PATH}/${DEAL_II_PROJECT_CONFIG_RELDIR}/${DEAL_II_PROJECT_CONFIG_NAME}ConfigGit.cmake")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this work before?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would guess that this file is just not regularly used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bangerth This did not work before. But this is how it is intended to be used (sans workaround): conservation-laws/ryujin@afdc795

@bangerth bangerth merged commit 2fa0c96 into dealii:master Apr 29, 2024
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants