Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macro_check_compiler_setup.cmake to correct the conflict betwe… #16746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BlueRain-debug
Copy link

Update macro_check_compiler_setup.cmake to correct the conflict between /O2 and /RTC1 under the default DEBUG configuration.

Set the CMAKE_TRY_COMPILE_CONFIGURATION flag independently for the combination of MSVC and DEAL_II_HAVE_USABLE_FLAGS_RELEASE.

Fixed the problem originally posted by @gsegon in #1921 (comment)

…en /O2 and /RTC1 under the default DEBUG configuration

Set the CMAKE_TRY_COMPILE_CONFIGURATION flag independently for the combination of MSVC and DEAL_II_HAVE_USABLE_FLAGS_RELEASE.

Fixed the problem originally posted by @gsegon in dealii#1921 (comment)
@masterleinad
Copy link
Member

I would prefer to set the appropriate value at the call site and skip the test for MSVC if we don't know which one to use. Ultimately, this is only a sanity check anyway.

@bangerth bangerth added this to the Release 9.6 milestone Mar 20, 2024
@bangerth
Copy link
Member

bangerth commented Apr 2, 2024

@BlueRain-debug Did you have time to consider @masterleinad 's suggestion?

@BlueRain-debug
Copy link
Author

BlueRain-debug commented Apr 13, 2024

I would prefer to set the appropriate value at the call site and skip the test for MSVC if we don't know which one to use. Ultimately, this is only a sanity check anyway.

Thank you very much for your reply. I'm sorry that I didn't check it in time these days.

I think this sanity check should still be considered necessary for MSVC to avoid the problem when the user manually specifies a CXX flag that is not supported by the compiler, while also allowing user to quickly find the problem at that time.

In addition, the macro (check_compiler_setup) is being used in multiple files, so skipping it at the call point might make the CMAKE process too complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants