Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare conversion assignments for Tpetra vectors. #16639

Closed
wants to merge 1 commit into from

Conversation

bangerth
Copy link
Member

As noted in #16636 (comment) by @jpthiele , we need conversion assignment operators for Tpetra vectors. I had actually started to write those, but don't have time today or tomorrow to finish them. I'll upload it in case someone else wants to finish my work -- this compiles for several more tests, but obviously produces linker errors.

@jpthiele
Copy link
Contributor

This is certainly a good step but it also would be interesting if we could manage shallow copies
between the types so we can use a Tpetra solver and the built-in solution vector updates.

But for that we possibly need all that view stuff and @masterleinad might now how to manage that.

@bangerth
Copy link
Member Author

That raises difficult ownership questions. My suggestion would be to get these operators implemented first. We can implement more elaborate schemes later on.

@jpthiele
Copy link
Contributor

That raises difficult ownership questions. My suggestion would be to get these operators implemented first. We can implement more elaborate schemes later on.

I totally agree that that is the more elaborate one and should be thought about carefully.
And we don't necessarily need to expose that as a functionality to the user.
But it would be much more convenient for the user to pass Vector or LA::d::Vector to the solve functions in SolverDirect and the iterative counterpart.

@masterleinad
Copy link
Member

Superseded by #16663.

@bangerth bangerth deleted the t-6 branch February 20, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants