Testsuite: remove implicit target dependencies when possible (ninja support) #16555
+41
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first part in a series of testsuite performance improvements.
Remove unnecessary, implicit target dependencies in our testsuite between for tests with shared executable targets. These are all test variants where multiple tests share a single executable target, such as, for example MPI tests:
Here, we ensure that an executable
foobar
is built from thefoobar.cc
sources before running either of the two test variants. This happens by first creating an executable target forfoobar
and then creating a testtest_dependency/category.foobar.(debug|release).executable
and require it to run before thecategory/foobar.(debug|release)
with the help of CTEST'sFIXTURES_REQUIRED
mechanism.We need this in order to support ninja for the testsuite: concurrent invocation of ninja (as we do in the testsuite) can lead to an incomplete
.ninja_log
file so that subsequent invocations do not rebuild the executable (which leads to unnecessary compilation times, and worse, race conditions).