Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions: simplify oneAPI setup with external action. #16363

Merged
merged 1 commit into from May 14, 2024

Conversation

marcfehling
Copy link
Member

@marcfehling marcfehling commented Dec 18, 2023

This means we have one less thing to worry about.

See: https://github.com/rscohn2/setup-oneapi

Copy link
Member

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How stable (and future-proof) is this action? What we are doing right now at least follows https://www.intel.com/content/www/us/en/docs/oneapi/installation-guide-linux/2024-0/apt.html#GUID-B1770241-0BBB-4E9C-B85B-9268CA66F15C.

@marcfehling
Copy link
Member Author

marcfehling commented Dec 18, 2023

The author works for Intel and is actively involved in the oneAPI project, including oneapi-src/oneapi-ci. Developing a github action was an early request in oneapi-src/oneapi-ci#31. It seems like the author of this action took the matter into his own hands.

This action is not using the Intel repository, but relies on links to the individual Intel packages, see rscohn2/setup-oneapi/src/main.js. In addition to caching (as we do already), it also deletes unused files from the installation (pruning), which is a step forward from our approach.

I believe it is worthwhile to adopt this action, to (A) centralize the oneAPI installation process and no longer have to take care of it ourselves, and (B) by promoting this action and the efforts of the author to show that there is a demand. However, I do not know what they have in mind for the future of this action, but I hope they consider making it more official by moving it into the oneapi-src group.

@bangerth bangerth changed the title github-actions: simply oneAPI setup with external action. github-actions: simplify oneAPI setup with external action. Dec 21, 2023
@bangerth
Copy link
Member

/rebuild

@bangerth
Copy link
Member

I don't know enough about the CI setup to say which way to go. Someone want to give a thumbs up/down on this?

Copy link
Member

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@masterleinad masterleinad merged commit 55cee43 into dealii:master May 14, 2024
15 checks passed
@marcfehling marcfehling deleted the oneapi branch May 14, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants