Merge pull request #24 from dealertrack/swap

added ListSerializer to SwappingSerializerMixin

HISTORY.rst

@@ -3,7 +3,13 @@
 History
 -------
 
+0.3.1 (2018-11-07)
+~~~~~~~~~~~~~~~~~~
+
+* Fixing ``SwappingSerializerMixin`` by supporting ``ListSerializer``
+
 0.3.0 (2018-11-05)
+~~~~~~~~~~~~~~~~~~
 
 * Added ``SwappingSerializerMixin``.
   Allows to declaratively swap fields any field instances in child serializers.

drf_braces/__init__.py

@@ -4,4 +4,4 @@
 
 __author__ = 'Miroslav Shubernetskiy'
 __email__ = 'miroslav@miki725.com'
-__version__ = '0.3.0'
+__version__ = '0.3.1'

drf_braces/serializers/swapping.py

@@ -2,7 +2,7 @@
 from __future__ import absolute_import, print_function, unicode_literals
 import copy
 
-from rest_framework.serializers import BaseSerializer
+from rest_framework.serializers import BaseSerializer, ListSerializer
 
 
 class SwappingSerializerMixin(BaseSerializer):
@@ -33,7 +33,9 @@ def swap_fields(self, serializer):
             new_field = self.swap_field(field)
             if new_field is not field:
                 serializer.fields[name] = new_field
-            if isinstance(new_field, BaseSerializer):
+            if isinstance(new_field, ListSerializer):
+                self.swap_fields(new_field.child)
+            elif isinstance(new_field, BaseSerializer):
                 self.swap_fields(new_field)
         return serializer
 

drf_braces/tests/serializers/test_swapping.py

@@ -23,6 +23,7 @@ class ParentSerializer(serializers.Serializer):
 
 class GrandParentSerializer(serializers.Serializer):
     parent = ParentSerializer()
+    parents = ParentSerializer(many=True)
 
 
 class TestSwappingSerializerMixin(unittest.TestCase):
@@ -36,3 +37,4 @@ class Meta(object):
         swapped = Swappable()
 
         self.assertIsInstance(swapped.fields['parent'].fields['child'], ChildAlternativeSerializer)
+        self.assertIsInstance(swapped.fields['parents'].child.fields['child'], ChildAlternativeSerializer)