Skip to content

Commit

Permalink
Fix misleading comment at the top of procfile.rb that indicates that …
Browse files Browse the repository at this point in the history
…hyphens "-" are not allowed in process names.

Several of the ports listed in the README have incorrectly not allowed hyphens to be present in process names.  I believe
it's because they took inspiration from this misleading comment at the top of the procfile.rb file.

[Haskell](https://github.com/fujimura/houseman/blob/f4a5da44a35a04c84694118c91894bda41efaaa0/src/Procfile/Parse.hs#L21)
[Go](https://github.com/mattn/goreman/blob/ebb9736b7c7f7f3425280ab69e1f7989fb34eadc/main.go#L103)
[Java](https://github.com/owenthereal/gaffer/blob/5704f4de1d438cc6527f7f4b5a439940607ccd54/src/main/java/gaffer/procfile/Procfile.java#L14)
  • Loading branch information
benwilber authored and ddollar committed Apr 12, 2024
1 parent 0fe6bc9 commit 4693875
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/foreman/procfile.rb
Expand Up @@ -4,7 +4,7 @@
#
# A valid Procfile entry is captured by this regex:
#
# /^([A-Za-z0-9_]+):\s*(.+)$/
# /^([A-Za-z0-9_-]+):\s*(.+)$/
#
# All other lines are ignored.
#
Expand Down

0 comments on commit 4693875

Please sign in to comment.