-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix a couple of broken link fragments #6197
Conversation
Most likely, the local I don't see any warnings in the master build: |
It's actually the markdownlint check that gets it, which is done in docs check. I have markdownlint 0.40.0 |
Oh, we're using https://github.com/avto-dev/markdown-lint - which is using a vastly outdated markdownlint, seems unmaintained? |
I see, but now mkdocs complains:
And this link doesn't work http://127.0.0.1:8000/en/stable/developers/testing-docs/#fork--clone-the-ddev-repository But the previous link does http://127.0.0.1:8000/en/stable/developers/testing-docs/#fork-clone-the-ddev-repository |
It looks like we have plenty of other options, https://github.com/marketplace?category=&type=actions&verification=&query=sort%3Apopularity-desc+markdownlint |
I agree with you.
So this should be reverted and I'll have to figure out my local checks I guess. |
This reverts commit 41f38c7.
The linter in GitHub actions doesn't seem to be complaining at all. https://github.com/ddev/ddev/actions/runs/9104906017/job/25029577157#step:10:9
Yes, I have the same release and see the same errors in |
The Issue
Two Markdown link fragments were broken, and markdownlint was catching it, at least locally.