Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix Codespaces link #6196

Merged
merged 1 commit into from
May 16, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented May 16, 2024

The Issue

Open in GitHub Codespaces

The link above ⬆️ opens the wrong repo, and the branch is not selected:

image

How This PR Solves The Issue

Fixes the link.
I also removes autostart from Gitpod link, because it should really have confirmation before creating a new workspace.

Manual Testing Instructions

The link below works ⬇️

Open in GitHub Codespaces

image

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested review from a team as code owners May 16, 2024 13:59
Copy link

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please make it open in new windows/tab while we're here, thanks!

@stasadev
Copy link
Member Author

stasadev commented May 16, 2024

I'd also like to open it in a new window/tab, but that's not possible at the moment:

@rfay rfay self-requested a review May 16, 2024 14:34
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rfay rfay merged commit 9ea03b6 into ddev:master May 16, 2024
28 of 29 checks passed
@stasadev stasadev deleted the 20240516_stasadev_fix_codespaces_link branch May 16, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants