Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieve Drupal 11 sqlite3 packages from snapshot.debian.org #6175

Merged
merged 1 commit into from
May 13, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented May 10, 2024

The Issue

Suddenly we're not able to support sqlite/libsqlite 3.45.1 because it's gone from the repo we were pulling it from, so Drupal 11 startup fails.

How This PR Solves The Issue

Pull from snapshot.debian.org

I do wonder if we should only grab the 3.45 sqlite if they have omit_containers[db].

I don't understand why we didn't catch this in latest test on master (https://github.com/ddev/ddev/actions/runs/9035899711/job/24831603173) unless they just removed the package between the time that started and when I was testing. (Search for "DdevFullSiteSetup for TestPkgDrupal11"). Code is in

// Special installed sqlite3 test for drupal11.
if app.Type == nodeps.AppTypeDrupal {
drupalVersion, err := ddevapp.GetDrupalVersion(app)
if err == nil && drupalVersion == "11" {
stdout, stderr, err := app.Exec(&ddevapp.ExecOpts{
Cmd: "sqlite3 --version | awk '{print $1}'",
})
require.NoError(t, err, "sqlite3 --version failed, output=%v, stderr=%v", stdout, stderr)
stdout = strings.Trim(stdout, "\r\n")
require.Equal(t, versionconstants.Drupal11RequiredSqlite3Version, stdout)
}
}

I did manually test TestDdevFullSiteSetup with drupal11 on master and it failed there and succeeds here.

Manual Testing Instructions

Start a d11 project

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rfay rfay requested a review from a team as a code owner May 10, 2024 20:21
@rfay rfay marked this pull request as draft May 10, 2024 20:21
Copy link

@rfay rfay marked this pull request as ready for review May 10, 2024 20:51
@rfay rfay requested a review from stasadev May 10, 2024 20:51
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it's a good thing we didn't make a release with ftp.debian.org.

@rfay rfay merged commit ac926de into ddev:master May 13, 2024
25 of 26 checks passed
@rfay rfay deleted the 20240510_snapshot_sqlite_3_45 branch May 13, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants