Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use newer technique to cancel in-progress builds #6172

Merged
merged 1 commit into from
May 10, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented May 10, 2024

The Issue

Someone pointed out that the use of https://github.com/styfle/cancel-workflow-action is no longer necessary. I think it was @tyler36, thanks!

There's a native technique, and the top of stylfle/cancel-workflow-action even calls it out.

image

How This PR Solves The Issue

Use the newer technique.

@rfay rfay requested a review from a team as a code owner May 10, 2024 16:10
@rfay rfay changed the title tests: Use newer technique to cancel in-progress builds test: Use newer technique to cancel in-progress builds May 10, 2024
@rfay rfay requested a review from stasadev May 10, 2024 16:14
Copy link

@rfay rfay added this to the v1.23.1 milestone May 10, 2024
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

The idea comes from this PR:

@rfay rfay force-pushed the 20240510_cancel_running branch from 4d096ed to 1d138af Compare May 10, 2024 17:25
@rfay rfay merged commit 485a2b5 into ddev:master May 10, 2024
22 checks passed
@rfay rfay deleted the 20240510_cancel_running branch May 10, 2024 17:28
@stasadev
Copy link
Member

stasadev commented May 14, 2024

I don't know why, but after this change, when I create a new PR, I always get an email about this:

https://github.com/ddev/ddev/actions/runs/9078236290

PR Check
Canceling since a higher priority waiting request for 'PR Check-refs/heads/master' exists

Looking at the log of various actions, I see that some of them also have Canceling since a higher priority waiting request.

@rfay
Copy link
Member Author

rfay commented May 14, 2024

I saw several of your PR runs get hung up yesterday, never getting assigned a runner. I restarted them, but didn't read them closely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants