fix: check for valid db version in ddev debug migrate-database
#6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR.
|
rfay
reviewed
May 9, 2024
| @@ -207,7 +209,7 @@ func GetValidMariaDBVersions() []string { | |||
| // IsValidPostgresVersion is a helper function to determine if a PostgreSQL version is valid, returning | |||
| // true if the supplied version is valid and false otherwise. | |||
| func IsValidPostgresVersion(v string) bool { | |||
| if _, ok := ValidPostgresVersions[v]; !ok { | |||
| if _, ok := ValidPostgresVersions[strings.TrimPrefix(v, Postgres+":")]; !ok { | |||
There was a problem hiding this comment.
Should this be Postgres or postgres ?
There was a problem hiding this comment.
Postgres, this is a constant:
Lines 17 to 22 in 195334d
rfay
approved these changes
May 10, 2024
| func IsValidMariaDBVersion(MariaDBVersion string) bool { | ||
| if _, ok := ValidMariaDBVersions[MariaDBVersion]; !ok { | ||
| func IsValidMariaDBVersion(v string) bool { | ||
| if _, ok := ValidMariaDBVersions[strings.TrimPrefix(v, MariaDB+":")]; !ok { |
There was a problem hiding this comment.
So these were only used in ddev debug migrate-database and were always wrong?
There was a problem hiding this comment.
Yes, that's right.
I didn't even know the validator was broken, the condition in ddev debug migrate-database looked strange and I investigated it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Fixed the condition for valid db versions. I came across it and couldn't understand how it worked before. During debugging, I saw that instead of the version, for example,
8.0, the whole stringmysql:8.0was passed inside.Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes