Skip to content

Commit

Permalink
fix: codespaces needs https port as base
Browse files Browse the repository at this point in the history
  • Loading branch information
rfay committed Apr 16, 2024
1 parent a0620b8 commit 93b0218
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/ddevapp/ddevapp.go
Original file line number Diff line number Diff line change
Expand Up @@ -2625,7 +2625,7 @@ func (app *DdevApp) GetAllURLs() (httpURLs []string, httpsURLs []string, allURLs
codespaceName := os.Getenv("CODESPACE_NAME")
previewDomain := os.Getenv("GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN")
if codespaceName != "" && previewDomain != "" {
url := fmt.Sprintf("https://%s-%s.%s", codespaceName, app.HostWebserverPort, previewDomain)
url := fmt.Sprintf("https://%s-%s.%s", codespaceName, app.HostHTTPSPort, previewDomain)
httpsURLs = append(httpsURLs, url)
}
}
Expand Down

0 comments on commit 93b0218

Please sign in to comment.