Implement foundation page as markdown, with MarkdownTemplate.astro #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
fdeac07
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f4d2d55c.ddev-com-front-end.pages.dev |
| Branch Preview URL: | https://20230811-markdown-pages.ddev-com-front-end.pages.dev |
rfay
force-pushed
the
20230811_markdown_pages
branch
from
69f728d
to
fdeac07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Watching https://craftquest.io/courses/astro-quick-start-guide/50358 I was inspired to try to make top-level markdown work on ddev.com
How This PR Solves The Issue
Uses the basic approaches there along with @mattstein suggestions, especially the Tailwind "prose" class. It works OK at this point but is not ready for prime time.
* I couldn't get it to build if I added in the<SEO>componentManual Testing Instructions
https://20230811-markdown-pages.ddev-com-front-end.pages.dev/foundation/
Thanks for your help so far @mattstein - I'd be happy to book a session with you to look at this or also happy to receive async comments.