Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add honor cipher suites #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add honor cipher suites #285

wants to merge 1 commit into from

Conversation

bashims
Copy link

@bashims bashims commented May 14, 2018

No description provided.

@bashims
Copy link
Author

bashims commented May 14, 2018

This feature request requires openjdk-1.8, but it seems that travis job requires openjdk-1.7. What's the best way to go about addressing multi JDK version support?

Thanks,

-ben

@gunterze
Copy link
Member

gunterze commented Jun 1, 2018

You may use reflection to only invoke SSLContext.setUseCipherSuitesOrder(boolean) if the method exists.
You should also take care that LDAP does not guarantee, to preserve the order of multiple values. So you cannot rely on the order of String[] tlsCipherSuites!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bashims @gunterze