Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caught File.open() exception and print error #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

doge1024
Copy link

@doge1024 doge1024 commented Dec 3, 2020

No description provided.

@dblock
Copy link
Owner

dblock commented Dec 3, 2020

What are you seeing now that you wanted to catch this error? What was the old behavior vs. new behavior?

I am not saying we don't want this, but there are things I dislike:

@dangerpr-bot
Copy link

2 Warnings
⚠️ [DEPRECATION] check is deprecated. Please use check! instead.
⚠️ Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#40](https://github.com/dblock/fui/pull/40): Caught file.open() exception and print error - [@doge1024](https://github.com/doge1024).

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants