Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix odata batch support #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cfranchuk
Copy link

@cfranchuk cfranchuk commented Jan 23, 2020

David, I re-implemented many of the same changes as before to fix the OData Batch support for .NET Core and .NET Standard.

This time I went with the approach of implementing the least changes to existing projects to maintain backwards compatibility as much as possible.

Full Framework

  • Nuget packages and dependencies are NOT changed.
  • Batch logic was modified to explicitly set the HTTP header version to 1.1 because the newer 'HttpRequestMessage' will default the HTTP header version to 2.0 which will cause an error.

.NET Core

  • Upgraded the framework to 2.1 LTS.
  • Upgrade Newtonsoft from 9.x to 11.x

.NET Standard

  • Dropped support for .NET standard 1.4.
  • Existing Nuget package versions remain the same.

Added a .NET core unit test project to verify that equivalent functionality exists between .NET Full Framework and .NET Core.

@cfranchuk cfranchuk marked this pull request as ready for review July 27, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant