Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NTLM option for On Premise CRM's #54

Closed
wants to merge 3 commits into from

Conversation

d4hines
Copy link

@d4hines d4hines commented Feb 9, 2018

This addresses the Node side of #33. I've added the option to use NTLM authentication against On-Premise CRM. I've done this using request-ntlm, specifically FrankyBoy's branch, as the main branch is broken. This branch is published as request-ntlm-continued on npm. Please let me know if you have any suggestions/objections to anything.

@d4hines d4hines mentioned this pull request Feb 9, 2018
@d4hines
Copy link
Author

d4hines commented Feb 12, 2018

Looks like there are some issues with the return data of some requests. It's breaking when I try to integrate with gulp-webresource. Let me add some better handling of the return data and try again.

@davidyack
Copy link
Owner

Thanks @d4hines for submitting this...one of the things I'm struggling with is trying to keep auth out of the = library...you probably notice we don't bake in ADAL libs, 'm not sure I really want to take a dependency on the ntlm lib. Let me take a look a bit at what you did to get it working, and see if I have any suggestions on how we could keep it more loosely coupled

@d4hines
Copy link
Author

d4hines commented Feb 12, 2018 via email

@davidyack
Copy link
Owner

Rather than keep this hanging around closing for now

@davidyack davidyack closed this Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants