Merge branch 'release-13.0.3'

davidtsadler · Sep 7, 2017 · 00785e2 · 00785e2
2 parents d0274d6 + f3a0533
commit 00785e2
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # CHANGELOG
 
+## 13.0.3 - 2017-09-07
+
+## Fixes
+
+- It appears that PostOrder\Types\UploadFileRequest::data may be a string and not an array as
+ stated in the documentation.
+
 ## 13.0.2 - 2017-08-28
 
 ## Fixes

diff --git a/src/PostOrder/Types/UploadFileRequest.php b/src/PostOrder/Types/UploadFileRequest.php
@@ -24,7 +24,7 @@ class UploadFileRequest extends \DTS\eBaySDK\Types\BaseType
     private static $propertyTypes = [
         'data' => [
             'type' => 'string',
-            'repeatable' => true,
+            'repeatable' => false,
             'attribute' => false,
             'elementName' => 'data'
         ],

diff --git a/src/Sdk.php b/src/Sdk.php
@@ -30,7 +30,7 @@
  */
 class Sdk
 {
-    const VERSION = '13.0.2';
+    const VERSION = '13.0.3';
 
     /**
      * @var bool Controls if the SDK should enforce strict types

diff --git a/test/property_fixes/PropertyFixesTest.php b/test/property_fixes/PropertyFixesTest.php
@@ -162,4 +162,18 @@ public function testGaleryURL()
         $obj->GalleryURL = 'foo';
         $this->assertInternalType('string', $obj->GalleryURL);
     }
+
+    /**
+     * Incorrect documentation https://developer.ebay.com/Devzone/post-order/types/UploadFileRequest.html
+     * Issue: https://github.com/davidtsadler/ebay-sdk-php/issues/133
+     * PR: https://github.com/davidtsadler/ebay-sdk-php/pull/134
+     */
+    public function testUploadFileRequest()
+    {
+        $obj = new Sdk\PostOrder\Types\UploadFileRequest();
+
+        $obj->data = '';
+
+        $this->assertInternalType('string', $obj->data);
+    }
 }