Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tri-state checkboxes for groups and changing caret-container icon #830

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oltur
Copy link

@oltur oltur commented Nov 10, 2016

No description provided.

@S-t-e-p-s
Copy link
Contributor

S-t-e-p-s commented Nov 11, 2016

why do you push useless changes? spaces, It is really hard to review it. :(
Try to review your changes and you will get my point.
Title of your PR got my attention, I also need this thing, but it's really hard to understand what was changed.

@oltur
Copy link
Author

oltur commented Nov 11, 2016

Hi,

Sorry for that, it was an autoformatting from Visual Studio I hadn't time
to revert.
Hoped you could autoformat it back and it could be useful.


Yours faithfully,
Alex Turevski

On Fri, Nov 11, 2016 at 3:16 PM, Stepan Tynskyi notifications@github.com
wrote:

why do you push useless changes? spaces It is really hard to review it.
:(
Try to review your changes and you will get my point.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#830 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADi1IIObVC4CMfr9jj3TH8PwfjcOY9Gqks5q9GqYgaJpZM4KuV-m
.

@davidstutz
Copy link
Owner

Agree with @S-t-e-p-s. Thanks anyway, any contribution is appreciated.

I am also missing a description. I can't really see what issue this PR fixes or which feature it adds.

@dten
Copy link

dten commented Apr 14, 2021

As someone who was looking for this feature I can tell what it's supposed to do

If you have a group with some but not all of its elements selected the group checkbox will show indeterminate so that when it's collapsed you can tell it has something inside ticked

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants