Add initconfig support for command defaults, allow strings as config keys #257
Conversation
| @@ -0,0 +1,17 @@ | |||
| # adapted from https://gist.github.com/Integralist/9503099 | |||
| class Object | |||
There was a problem hiding this comment.
Can we not monkeypatch core classes? This is likely going to break anyone that uses GLI with Rails/ActiveSupport.
There was a problem hiding this comment.
Looking over the rest of the PR, I think a better way to do this is make a class whose job is to load the configuration and have it do all this string/symbol copying, so we don't infect every object in the entire system with a method that's only needed in a couple of places.
There was a problem hiding this comment.
Yes, that's fair. It hadn't occurred to me that a GLI project might also have ActiveSupport loaded.
|
Thanks for doing this! Other than the issues with monkeypatching, the overall change looks great! |
|
Got rid of the monkeypatching, which I admit was reckless. |
|
|
||
| # adapted from https://gist.github.com/Integralist/9503099 | ||
| def self.apply_indifferent_access_to(obj) | ||
| return obj.reduce({}) do |memo, (k, v)| |
There was a problem hiding this comment.
Sorry to nitpick, but can you use a more traditional if construct? Trailing ifs for multiple lines is really confusing to me.
|
Thanks and sorry for the delay in looking at this. Just one tiny nitpick, but otherwise this looks good. Thanks! |
Fixes #63
The
initconfigcommand will now write out all of the switches and flags for any commands and any subcommands. It writes config keys as strings, though symbols will still work.