Commands from works when namespaced #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,12 +30,13 @@ module App | |||
| # # loads *.rb files from the user's home dir - great and an extension/plugin mechanism | |||
| # commands_from File.join(ENV["HOME"],".my_app","plugins") | |||
| def commands_from(path) | |||
| b = GLI::App.send(:binding) | |||
There was a problem hiding this comment.
Unfortunately, require at any level of scope puts the code in global scope, meaning that if a GLI app wraps itself in a namespace, everything loaded via commands_from doesn't work.
The solution here is to grab the binding from GLI::App (where all the DSL commands are defined) and then eval the external commands. Yikes, I know.
|
old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test for #201 and a more general fix. Not sure if this is what I want to do