feature: Update addYears function to make it timezone agnostic conversion #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 25, 2024 10:32
…ting the date from UTC.
…ting the date from UTC.
…ic' into feature/addYears_timezone_agnostic # Conflicts: # src/addYears/test.ts
…ting the date from UTC.
…ting the date from UTC.
kossnocorp
requested changes
May 13, 2024
There was a problem hiding this comment.
Hey, thank you for the PR.
But before moving on, can you please expand on what it does? The PR links to itself, and while I can guess, I would rather see a clear explanation of the problem.
Even if it's a breaking change, there must be a solid reason to update existing tests. Furthermore, I would ask you not to use UTC in the tests because it prevents the timezone tests from catching bugs. They should pass regardless of the timezone, and if they don't, I would like to know why so I can advise you on how to approach it properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the function AddYears to be timezone Agnostic. addYears gives different results depending on system timezone
Resolves:
#3783