3763 parse iso fix #3780
Open
3763 parse iso fix #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kossnocorp
requested changes
May 14, 2024
| it("parses YY", () => { | ||
| const result = parseISO("20"); | ||
| expect(result).toEqual(new Date(2000, 0 /* Jan */, 1)); | ||
| expect(result.getUTCFullYear()).toEqual(19); |
There was a problem hiding this comment.
Please compare with a full date like before, as it prevents other date components from being parsed incorrectly.
| year = '0' + year; | ||
| } | ||
| return year; | ||
| } |
There was a problem hiding this comment.
Please use addLeadingZeros from src/_lib/addLeadingZero/index.ts
| date.setFullYear(-2000, 0 /* Jan */, 1); | ||
| date.setHours(0, 0, 0, 0); | ||
| expect(result).toEqual(date); | ||
| const result = parseISO("20", { additionalDigits: 0 }); |
There was a problem hiding this comment.
I prefer to keep the tests as is and update/add only what is required. Here, it needs to be clarified how these changes relate to the PR goal.
There was a problem hiding this comment.
Hi, thanks for the feedback. I will apply all of the recomendations, and submit again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problema:
parseISO parses number '30' on a date with the year 3000.
const { parseISO} = require('date-fns');
console.log(parseISO('30')); // prints '3000-01-01T08:00:00.000Z'
Soluction:
Since the parseISO function in its documentation receives dates in full format (YYYY-MM-DDTHH:mm:ss.sssZ
) or dates in partial format (YYYY-MM-DD, YYYY-MM, YYYY) a code was added that sends all years with less than 4 digits to 4-digit years, this way the function correctly returns the dates as happens with entries 0001, 0030, 0999 which translates into 0001-01-01T00:00:00, 0030-01-01T00:00:00, 0999-01-01T00:00:00 respectively.
And as a reference, tests being implemented with the same purpose in Go language respond as invalid input and only allow dates in the full format.: Test in Go Lang