Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3769 longformatter exporter twice #3770

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomalaforge
Copy link

remove one export of longFormatter.

Library users can still export it from the parse file.

@fturmel
Copy link
Member

fturmel commented Apr 16, 2024

The export from parse should be the one removed or renamed imo since it's more logical to colocate longFormatters with the format function. MUI X is also already consuming the format export.

@tomalaforge
Copy link
Author

The export from parse should be the one removed or renamed imo since it's more logical to colocate longFormatters with the format function. MUI X is also already consuming the format export.

Yes makes sense. I'll make the change

@Xhale1
Copy link

Xhale1 commented May 13, 2024

Do you need anything from the community to help with this PR? Sentry 8.0.0 just came out with some ESM improvements and this particular issue cropped up for me when trying to use the node --import flag which was recommended in their docs.

@tomalaforge
Copy link
Author

Do you need anything from the community to help with this PR? Sentry 8.0.0 just came out with some ESM improvements and this particular issue cropped up for me when trying to use the node --import flag which was recommended in their docs.

what do you mean ? just waiting for the maintainer to merge it.
for now I patched it on my project.

@Xhale1
Copy link

Xhale1 commented May 16, 2024

what do you mean ? just waiting for the maintainer to merge it. for now I patched it on my project.

Gotcha, makes sense. I was curious if this PR needed any additional work before being ready to merge. Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when using experimental loader flag, issue with longFormatter being exported twice
3 participants