formatDuration: Include undefined values if formatting with zero option set to true #3703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I provide format values in
FormatDurationOptions
and setzero
totrue
, I'm expecting also undefinedDuration
values to be considered in the output.Example
Input
Actual output:
10 seconds
Expected output:
Since I've explicitly set hours, minutes, and seconds I'm expecting to see them as 0 in the output.
0 hours 0 minutes 10 seconds
Note: It seems this was working like expected in 2.x but it is not working anymore in 3.x.
If this is the wanted behaviour instead, I suggest to update the relative doc in order to avoid misleading interpretations of
zero
param.