New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3210] improve(web): add checking table properties to the web e2e test #3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ch3yne Could you add a snapshot to show us what's point of the test case verify? |
LGTM |
LauraXia123
approved these changes
May 15, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2024
…st (#3301) ### What changes were proposed in this pull request? add checking table properties to the web e2e test <img width="647" alt="image" src="https://github.com/datastrato/gravitino/assets/17310559/012fcd91-ab31-46a0-8e87-3c5d66ffd21f"> <img width="655" alt="image" src="https://github.com/datastrato/gravitino/assets/17310559/c226551b-24e2-4c5e-88aa-24c2cfb10c2f"> ### Why are the changes needed? Fix: #3210 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? IT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add checking table properties to the web e2e test
Why are the changes needed?
Fix: #3210
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
IT