[#2543] feat(spark-connector): support row-level operations to iceberg Table #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caican00
changed the title
caican00
force-pushed
the
refactor-table-and-support-row-level
branch
2 times, most recently
from
d66ff10
to
4d334aa
Compare
… to iceberg Table
caican00
force-pushed
the
refactor-table-and-support-row-level
branch
from
4d334aa
to
ae71559
Compare
|
Hi @FANNG1 could you help review this pr? thank you. |
FANNG1
reviewed
May 6, 2024
...ector/src/main/java/com/datastrato/gravitino/spark/connector/utils/SparkBaseTableHelper.java
Outdated
Show resolved
Hide resolved
...rk-connector/src/main/java/com/datastrato/gravitino/spark/connector/utils/ConnectorUtil.java
Outdated
Show resolved
Hide resolved
...rk-connector/src/main/java/com/datastrato/gravitino/spark/connector/utils/ConnectorUtil.java
Outdated
Show resolved
Hide resolved
...rk-connector/src/main/java/com/datastrato/gravitino/spark/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
...rk-connector/src/main/java/com/datastrato/gravitino/spark/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/com/datastrato/gravitino/integration/test/util/spark/SparkTableInfo.java
Show resolved
Hide resolved
FANNG1
reviewed
May 6, 2024
...ration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkCommonIT.java
Outdated
Show resolved
Hide resolved
...ion-test/src/test/java/com/datastrato/gravitino/integration/test/util/spark/SparkUtilIT.java
Outdated
Show resolved
Hide resolved
...test/java/com/datastrato/gravitino/integration/test/spark/iceberg/SparkIcebergCatalogIT.java
Outdated
Show resolved
Hide resolved
...test/java/com/datastrato/gravitino/integration/test/spark/iceberg/SparkIcebergCatalogIT.java
Outdated
Show resolved
Hide resolved
|
all comments have been addressed. cc @FANNG1 |
FANNG1
reviewed
May 7, 2024
...test/java/com/datastrato/gravitino/integration/test/spark/iceberg/SparkIcebergCatalogIT.java
Outdated
Show resolved
Hide resolved
...rk-connector/src/main/java/com/datastrato/gravitino/spark/connector/hive/SparkHiveTable.java
Outdated
Show resolved
Hide resolved
...rk-connector/src/main/java/com/datastrato/gravitino/spark/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/com/datastrato/gravitino/integration/test/util/spark/SparkTableInfo.java
Outdated
Show resolved
Hide resolved
|
all comments have been addressed except one in discussion. cc @FANNG1 |
FANNG1
reviewed
May 11, 2024
...rk-connector/src/main/java/com/datastrato/gravitino/spark/connector/hive/SparkHiveTable.java
Outdated
Show resolved
Hide resolved
...nector/src/main/java/com/datastrato/gravitino/spark/connector/iceberg/SparkIcebergTable.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/com/datastrato/gravitino/spark/connector/utils/GravitinoTableInfoHelper.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/com/datastrato/gravitino/integration/test/util/spark/SparkTableInfo.java
Outdated
Show resolved
Hide resolved
|
@jerryshao @qqqttt123 do you have time to review? Overall LGTM except minor comment. |
|
@FANNG1 all comments have been addressed. |
|
If this is a user-facing change, you should add the documents. |
…can00/gravitino into refactor-table-and-support-row-level
done. |
|
@FANNG1 could you help review again? |
|
@caican00 could you fix the conflict? |
|
@qqqttt123 do you have other comments? |
…table-and-support-row-level
…can00/gravitino into refactor-table-and-support-row-level
done |
|
Hi @FANNG1 @qqqttt123 are there any else comments to fix? |
FANNG1
approved these changes
May 13, 2024
LGTM，will merge the PR if no other comments this afternoon |
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2024
…g Table (#3243) ### What changes were proposed in this pull request? - refactor table implementation, make `SparkIcebergTable` extend Iceberg `SparkTable`, and `SparkHiveTable` extend Kyuubi `HiveTable`. - support row-level operations to iceberg Table ``` 1. update tableName set c1=v1, c2=v2, ... 2. merge into targetTable t using sourceTable s on s.key=t.key when matched then ... when not matched then ... 3. delete from table where xxx ``` ### Why are the changes needed? 1. For spark-connector in Iceberg, it explicitly uses `SparkTable` to identify whether it is an Iceberg table, so the `SparkIcebergTable` must extend `SparkTable`. 2. support row-level operations to iceberg Table. Fix: #2543 ### Does this PR introduce any user-facing change? Yes, support update ... , merge into ..., delete from ... ### How was this patch tested? New ITs.
|
@caican00 great process for supporting the Iceberg catalog, thanks for your work. |
caican00
added a commit
to caican00/gravitino
that referenced
this pull request
May 14, 2024
… to iceberg Table (datastrato#3243) ### What changes were proposed in this pull request? - refactor table implementation, make `SparkIcebergTable` extend Iceberg `SparkTable`, and `SparkHiveTable` extend Kyuubi `HiveTable`. - support row-level operations to iceberg Table ``` 1. update tableName set c1=v1, c2=v2, ... 2. merge into targetTable t using sourceTable s on s.key=t.key when matched then ... when not matched then ... 3. delete from table where xxx ``` ### Why are the changes needed? 1. For spark-connector in Iceberg, it explicitly uses `SparkTable` to identify whether it is an Iceberg table, so the `SparkIcebergTable` must extend `SparkTable`. 2. support row-level operations to iceberg Table. Fix: datastrato#2543 ### Does this PR introduce any user-facing change? Yes, support update ... , merge into ..., delete from ... ### How was this patch tested? New ITs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
refactor table implementation, make
SparkIcebergTableextend IcebergSparkTable, andSparkHiveTableextend KyuubiHiveTable.support row-level operations to iceberg Table
Why are the changes needed?
For spark-connector in Iceberg, it explicitly uses
SparkTableto identify whether it is an Iceberg table, so theSparkIcebergTablemust extendSparkTable.support row-level operations to iceberg Table.
Fix: #2543
Does this PR introduce any user-facing change?
Yes, support update ... , merge into ..., delete from ...
How was this patch tested?
New ITs.