Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] add checking for table Partitioning, SortOrders, Distribution, and Indexes to the web e2e test #3210

Closed
ch3yne opened this issue Apr 29, 2024 · 0 comments · Fixed by #3301
Closed

[Improvement] add checking for table Partitioning, SortOrders, Distribution, and Indexes to the web e2e test #3210

ch3yne opened this issue Apr 29, 2024 · 0 comments · Fixed by #3301
Assignees
@ch3yne
Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 improvement Improvements on everything

Comments

@ch3yne
Copy link
Contributor

ch3yne commented Apr 29, 2024

What would you like to be improved?

When creating a table, the columns may have specific partitioning, sort orders, distribution, indexes, and other fields that need to be validated in web e2e tests.

How should we improve?

Add checking for table Partitioning, SortOrders, Distribution, and Indexes to the web e2e test
@ch3yne ch3yne added the improvement Improvements on everything label Apr 29, 2024
@ch3yne ch3yne self-assigned this Apr 29, 2024
@ch3yne ch3yne added 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 labels Apr 30, 2024
@jerryshao jerryshao removed 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 labels May 1, 2024
@ch3yne ch3yne mentioned this issue May 8, 2024
Merged
@LauraXia123 LauraXia123 added 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 labels May 15, 2024
LauraXia123 pushed a commit that referenced this issue May 15, 2024
@ch3yne
[#3210] improve(web): add checking table properties to the web e2e te…
b24e9a6 
…st (#3301)

### What changes were proposed in this pull request?

add checking table properties to the web e2e test

<img width="647" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/012fcd91-ab31-46a0-8e87-3c5d66ffd21f">

<img width="655" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c226551b-24e2-4c5e-88aa-24c2cfb10c2f">



### Why are the changes needed?

Fix: #3210

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

IT
github-actions bot pushed a commit that referenced this issue May 15, 2024
@ch3yne @web-flow
[#3210] improve(web): add checking table properties to the web e2e te…
b043d4c 
…st (#3301)

### What changes were proposed in this pull request?

add checking table properties to the web e2e test

<img width="647" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/012fcd91-ab31-46a0-8e87-3c5d66ffd21f">

<img width="655" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c226551b-24e2-4c5e-88aa-24c2cfb10c2f">



### Why are the changes needed?

Fix: #3210

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

IT
@jerryshao jerryshao mentioned this issue May 15, 2024
Merged
LauraXia123 pushed a commit that referenced this issue May 17, 2024
@jerryshao @ch3yne
[#3210] improve(web): add checking table properties to the web e2e te…
2944fa4 
…st (#3400)

### What changes were proposed in this pull request?

add checking table properties to the web e2e test

<img width="647" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/012fcd91-ab31-46a0-8e87-3c5d66ffd21f">

<img width="655" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c226551b-24e2-4c5e-88aa-24c2cfb10c2f">



### Why are the changes needed?

Fix: #3210

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

IT

Co-authored-by: CHEYNE <contact@ch3yne.com>
jerryshao added a commit that referenced this issue May 20, 2024
@jerryshao
Revert "[#3210] improve(web): add checking table properties to the we…
2db87fb 
…b e2e te…"

This reverts commit 2944fa4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ch3yne ch3yne

Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3210] improve(web): add checking table properties to the web e2e test ch3yne/gravitino
3 participants
@jerryshao @LauraXia123 @ch3yne