modified handsontable, replace thrift client with new datahub client #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @michellekhuang, thanks for submitting the pull. @justinanderson and I are going to take a look at this tomorrow. |
|
Hey @michellekhuang - How is this accessible to the end user. I see that SampleClient is added, but am really not sure how to use it. |
|
@RogerTangos So this is run from a Datahub application, which still requires the user to change the redirect url. I asked Kimberly and she said this was the only way to get HandsOnTable to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the redirect url & client_id in main.js to debug on a different DataHub app.