Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entity-registry): Enforce Field Path V2 uniqueness check during ingestion #10477

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented May 9, 2024

Adds check in GMS when processing schemaMetadata aspects that all field paths are unique.
If that is not the case, reject the MCP.
The reason for this validator is that the UI will not be able to render schemas correctly if field path ids are not unique.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@pedro93
Copy link
Collaborator Author

pedro93 commented May 10, 2024

Failing test seems unrelated:

                                                                                                    
  Running:  domains/nested_domains.js                                                      (8 of 30)
  Estimated: 3 minutes, 5 seconds


  Verify nested domains test functionalities
=== 2024-05-09T23:20:04.443Z start: Verify Create a new domain
=== 2024-05-09T23:20:12.587Z end: Verify Create a new domain
    ✓ Verify Create a new domain (8115ms)
=== 2024-05-09T23:20:12.648Z start: Verify Documentation tab by adding editing Description and adding link
=== 2024-05-09T23:20:27.524Z end: Verify Documentation tab by adding editing Description and adding link
    ✓ Verify Documentation tab by adding editing Description and adding link (14694ms)
=== 2024-05-09T23:20:27.662Z start: Verify Right side panel functionalities
=== 2024-05-09T23:20:44.947Z end: Verify Right side panel functionalities
    ✓ Verify Right side panel functionalities (17245ms)
=== 2024-05-09T23:20:45.076Z start: Verify Move domain parent level to root level
xxx 2024-05-09T23:20:59.[560](https://github.com/datahub-project/datahub/actions/runs/9024237858/job/24798972167?pr=10477#step:31:561)Z error
    (Attempt 1 of 3) Verify Move domain parent level to root level
=== 2024-05-09T23:20:59.881Z end: Verify Move domain parent level to root level
=== 2024-05-09T23:21:00.041Z start: Verify Move domain parent level to root level
xxx 2024-05-09T23:21:14.531Z error
    (Attempt 2 of 3) Verify Move domain parent level to root level
=== 2024-05-09T23:21:14.740Z end: Verify Move domain parent level to root level
=== 2024-05-09T23:21:15.022Z start: Verify Move domain parent level to root level
xxx 2024-05-09T23:21:30.316Z error
    1) Verify Move domain parent level to root level
=== 2024-05-09T23:21:30.520Z end: Verify Move domain parent level to root level
=== 2024-05-09T23:21:30.716Z start: Verify Documentation tab by adding editing Description and adding link
=== 2024-05-09T23:21:47.372Z end: Verify Documentation tab by adding editing Description and adding link
    ✓ Verify Documentation tab by adding editing Description and adding link (16585ms)
=== 2024-05-09T23:21:47.494Z start: Verify Right side panel functionalities
=== 2024-05-09T23:22:07.371Z end: Verify Right side panel functionalities
    ✓ Verify Right side panel functionalities (19766ms)
=== 2024-05-09T23:22:07.529Z start: Verify Edit Domain Name
=== 2024-05-09T23:22:13.934Z end: Verify Edit Domain Name
    ✓ Verify Edit Domain Name (6294ms)
=== 2024-05-09T23:22:14.061Z start: Verify Remove the domain
=== 2024-05-09T23:22:22.513Z end: Verify Remove the domain
    ✓ Verify Remove the domain (8350ms)
=== 2024-05-09T23:22:22.815Z start: Verify Add and delete sub domain
=== 2024-05-09T23:22:38.122Z end: Verify Add and delete sub domain
    ✓ Verify Add and delete sub domain (15250ms)
=== 2024-05-09T23:22:38.274Z start: Verify entities tab with adding and deleting assets and performing some actions
=== 2024-05-09T23:23:05.593Z end: Verify entities tab with adding and deleting assets and performing some actions
    ✓ Verify entities tab with adding and deleting assets and performing some actions (27197ms)


  9 passing (3m)
  1 failing

  1) Verify nested domains test functionalities
       Verify Move domain parent level to root level:
     AssertionError: 2024-05-09T23:21:30.313Z
Timed out retrying after 10000ms: Expected to find element: `prev`, but never found it. Queried from:

              > cy.get([data-testid="domain-list-item"]).contains(Marketing)
  AssertionError: Timed out retrying after 10000ms: Expected to find element: `prev`, but never found it. Queried from:
  
                > cy.get([data-testid="domain-list-item"]).contains(Marketing)
      at moveDomaintoParent (webpack:///./cypress/e2e/domains/nested_domains.js:42:5)
      at Context.eval (webpack:///./cypress/e2e/domains/nested_domains.js:168:4)
      ```

@pedro93
Copy link
Collaborator Author

pedro93 commented May 10, 2024

Failing CI seems unrelated.

Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle patch or drop it as a supported operation please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants