Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to address bioconductor lesson issues from first beta #167

Merged
merged 13 commits into from
Jan 24, 2023
Merged

PR to address bioconductor lesson issues from first beta #167

merged 13 commits into from
Jan 24, 2023

Conversation

naupaka
Copy link
Member

@naupaka naupaka commented Nov 9, 2022

This is a PR to address issues raised in the first beta-pilot of the lesson (outlined in #142). All of the commits address problems identified in the bioconductor lesson.

It addresses:

@naupaka naupaka marked this pull request as draft January 11, 2023 16:44
@naupaka naupaka marked this pull request as ready for review January 11, 2023 17:57
@naupaka
Copy link
Member Author

naupaka commented Jan 11, 2023

@ytakemon @JasonJWilliamsNY @poterlowicz-lab This is now ready for review when you have a moment. Thanks!

@naupaka naupaka changed the title In progress PR to address bioconductor lesson issues PR to address bioconductor lesson issues from first beta Jan 11, 2023
@@ -21,17 +21,24 @@ source("../bin/chunk-options.R")
knitr_fig_path("04-")
```

<!-- example of rendered lesson https://datacarpentry.org/genomics-r-intro/02-r-basics/index.html -->
## Packages in R -- what are they and why do we use them?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this explanation! I noticed that we mention packages in the "R Basics continued" episode, but we don't explain it to this extent. I wonder if this would be a better fit in an earlier episode than in the Bioconductor one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think that probably makes sense. This is related to #170 -- if @JasonJWilliamsNY is ok with it I can pull this description out from here, and do a PR of the content on the R Basic continued lesson.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind -- might as well move fast and break things, eh? I pulled out the paragraph in commit c28e053 and will PR it to the earlier lesson separately. @ytakemon let me know if there are any other adjustments you think I should make or if this is ready to merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Merging.

@ytakemon
Copy link
Contributor

The rest of the commits look great @naupaka! I'd be happy to merge this request once we had a chance to discuss my comment above.

@ytakemon ytakemon merged commit 5084e86 into datacarpentry:main Jan 24, 2023
This was referenced Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants